chore(tracing): Use upstream tracing propagation#4286
Draft
sfleen wants to merge 2 commits intosfleen/tracing-upstream-exporterfrom
Draft
chore(tracing): Use upstream tracing propagation#4286sfleen wants to merge 2 commits intosfleen/tracing-upstream-exporterfrom
sfleen wants to merge 2 commits intosfleen/tracing-upstream-exporterfrom
Conversation
sfleen
changed the base branch from
main
to
sfleen/tracing-upstream-exporter
sfleen
changed the title
sfleen
force-pushed
the
sfleen/tracing-upstream-exporter
branch
from
6d66554 to
eff04ea
Compare
sfleen
force-pushed
the
sfleen/tracing-upstream-propagator
branch
from
d925933 to
bb81d3f
Compare
sfleen
force-pushed
the
sfleen/tracing-upstream-exporter
branch
2 times, most recently
from
0a11e90 to
dd0d5d9
Compare
sfleen
force-pushed
the
sfleen/tracing-upstream-propagator
branch
2 times, most recently
from
870d872 to
e460b63
Compare
The proxy used its own custom trace exporter for some time. It was built before the upstream OpenTelemetry libraries were available, and they have outlived their usefulness. This replaces the custom exporter with a batch exporter configured to export to the same endpoint with the same service configuration. In the future, this exporter can be installed as a global default trace processor, which would decouple it from the service layer where the proxy generates spans for requests. Signed-off-by: Scott Fleener <scott@buoyant.io>
The proxy used its own custom trace propagation for some time. It was built before the upstream OpenTelemetry libraries were available. This replaces the manual propagation with a combination of the upstream w3c and b3 propagators, modified slightly to only propagate in one format or the other (and not both). Signed-off-by: Scott Fleener <scott@buoyant.io>
sfleen
force-pushed
the
sfleen/tracing-upstream-exporter
branch
from
dd0d5d9 to
208b6b9
Compare
sfleen
force-pushed
the
sfleen/tracing-upstream-propagator
branch
from
e460b63 to
3d7b264
Compare
sfleen
force-pushed
the
sfleen/tracing-upstream-exporter
branch
from
208b6b9 to
2708010
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proxy used its own custom trace propagation for some time. It was built before the upstream OpenTelemetry libraries were available.
This replaces the manual propagation with a combination of the upstream w3c and b3 propagators, modified slightly to only propagate in one format or the other (and not both).