fix(outbound): fix clientpolicy not work after remove service profile#4064
Open
wgjak47 wants to merge 1 commit intolinkerd:mainfrom
Open
fix(outbound): fix clientpolicy not work after remove service profile#4064wgjak47 wants to merge 1 commit intolinkerd:mainfrom
wgjak47 wants to merge 1 commit intolinkerd:mainfrom
Conversation
wgjak47
force-pushed
the
main
branch
2 times, most recently
from
610d5d5 to
c8e92a8
Compare
This is a preview PR for linkerd/linkerd2#14274. In linkerd/idle-cache/src/lib.rs get_or_insert_with function, seems the sidercar with service profile and sidercar with client policy has the same key, which cause the cache didn't expire after we delete serviceprofile and create the new httproute for the target sevice for pods that keep requesting the target service. this pr try to create different keys for service profile httpsidecar and client policy httpsidecar Signed-off-by: Guanjie Wang <ak47m61@gmail.com>
Member
|
@wgjak47 thanks for submitting this. i should have some bandwidth to review next week. |
This comment was marked as off-topic.
This comment was marked as off-topic.
cratelyn
changed the title
Author
|
@olix0r Hi，Is there any improvement needed for this pr，or there is a better way to solve this problem？ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR for fixing linkerd/linkerd2#14274. In linkerd/idle-cache/src/lib.rs get_or_insert_with function, seems the sidercar with service profile and sidercar with client policy has the same key, which cause the cache didn't expire after we delete serviceprofile and create the new httproute for the target sevice for pods that keep requesting the target service. this pr will create different keys for service profile httpsidecar and client policy httpsidecar to fix this problem.