Skip to content

Conversation

@tisnik
Copy link
Contributor

@tisnik tisnik commented Jan 18, 2026

Description

LCORE-1201: reformatted sources by newest Black version

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-1201

Summary by CodeRabbit

  • Style

    • Whitespace and formatting adjustments across multiple files.
  • Bug Fixes

    • Removed module-level variables and logger initialization in utility and test modules.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 18, 2026

Walkthrough

The PR removes blank lines for formatting consistency across the codebase and eliminates module-level constants and logger initialization from several files. Most changes are whitespace adjustments; however, some files remove variable definitions that are referenced elsewhere, potentially causing runtime errors or test failures.

Changes

Cohort / File(s) Summary
Formatting: Blank line removals
dev-tools/mcp-mock-server/server.py, src/app/endpoints/query.py, src/quota/quota_limiter.py, tests/integration/endpoints/test_rlsapi_v1_integration.py, tests/unit/app/endpoints/test_a2a.py, tests/unit/app/endpoints/test_streaming_query.py, tests/unit/authentication/test_api_key_token.py, tests/unit/models/rlsapi/test_requests.py, tests/unit/models/rlsapi/test_responses.py, tests/unit/test_llama_stack_configuration.py
Removed empty blank lines between import blocks and code sections; purely formatting changes.
Logger initialization removal
src/utils/mcp_headers.py
Removed module-level logger initialization (logger = logging.getLogger("app.endpoints.dependencies")), but existing logger.error calls remain in the code, creating undefined name references. ⚠️ Requires attention
Test constant removals
tests/e2e/features/steps/llm_query_response.py
Removed DEFAULT_LLM_TIMEOUT constant (value: 60) used in requests.post calls; calls will now fail unless this constant is defined elsewhere. ⚠️ Requires attention
Test fixture identifier removals
tests/unit/cache/test_postgres_cache.py
Removed four module-level test constants: USER_ID_1, USER_ID_2, CONVERSATION_ID_1, CONVERSATION_ID_2; any tests referencing these will fail. ⚠️ Requires attention
Test configuration refactoring
tests/unit/test_configuration.py
Consolidated multiline YAML writes into single fout.write() statements; one test switched to f-string interpolation for dynamic path insertion. Functionally equivalent.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Most changes are straightforward formatting, but three files contain variable/constant removals that break references in other code paths, requiring verification that these are intentional and that consumers have been updated or that definitions exist elsewhere.

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: reformatting sources with the newest Black version, which is clearly evidenced by the systematic removal of blank lines across multiple files.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tisnik tisnik merged commit 3303303 into lightspeed-core:main Jan 18, 2026
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant