implement document.write #1274
Merged
implement document.write #1274
+87
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krichprollsch
force-pushed
the
document-write
branch
from
cbbdda8 to
6d4966e
Compare
karlseguin
approved these changes
Dec 14, 2025
src/browser/dom/document.zig
Outdated
| } | ||
|
|
||
| pub fn _write(self: *parser.Document, str: []const u8, page: *Page) !void { | ||
| if (!page.open) { |
Collaborator
There was a problem hiding this comment.
I think you can call _ = try _open(self, page) directly here (without the if check), since it does that if check for you. Seems better for write not to know about page.open if possible.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1266