Skip to content

Conversation

@pawelocode
Copy link

This change fixes an issue seen on specific devices since V2.20.0.

Im not sure if this is the best approach but hopefully this PR starts the conversation

@CLAassistant
Copy link

CLAassistant commented Dec 19, 2025

CLA assistant check
All committers have signed the CLA.

@yananazarenko417
Copy link

yananazarenko417 commented Dec 22, 2025

experiencing the same issue on both of my Samsungs. The renderer on 2.20.0 seems to be reading the texture coordinates even if it undefined / failed to load texture causing app crashes (black screen)

@wouterlucas
Copy link
Contributor

does that mean the texture creation is really slow on those devices? Does the rendering have a 1 or 2 frame artifact and then auto corrects or is this always going to be broken (ie the texture never got created versus its slow)?

@michielvandergeest
Copy link
Contributor

this PR originated from an issue that we could only reproduce on the slowest Sky Q device in combination with compressed textures (which may take longer to download because of the file size). So some slowness on devices could be responsible for this error

@pawelocode can you comment on the following question: Does the rendering have a 1 or 2 frame artifact and then auto corrects or is this always going to be broken (ie the texture never got created versus its slow)?

when you tested did the image ultimately correct itself? or remained broken forever? Even with this fix

@pawelocode
Copy link
Author

Hey Everyone so when I tested this I manually I made one of the low opacity fade asset fail and what I saw:
On the Q device the missing asset became a white rectangle (covering all content underneath) - this was the same on the previous version of the renderer.
The difference on the latest version is that nothing rendered as the app crashed without the safety

On the desktop browser just the asset was missing and the content in that area is still visible.
So in this state the PR just fixes the crash behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants