Allow password to be skipped or set to None in add_entry #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreyleavitt
added a commit
to coreyleavitt/pykeepass
that referenced
this pull request
Nov 29, 2025
… to None in add_entry Fixes TypeError when passing password=None to add_entry(), which the documentation already stated was allowed. See: libkeepass#418
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Allow skipping password or
password=Noneinadd_entryThis PR fixes an issue where skipping or passing
Noneas thepasswordtoadd_entrywould raise aTypeError, due tolxmlnot acceptingNonewhen building XML elements.According to the documentation:
https://libkeepass.github.io/pykeepass/pykeepass.html#PyKeePass.add_entry
The documentation already states that
Noneis allowed, but the code did not support it.What this PR does
<Password>field entirely ifpasswordisNone