code improvements #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonwang371
assigned
wilsonwang371,
liborui and
ShuFangLei and unassigned
liborui and
ShuFangLei
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the build process for WASM-JS samples in the
Makefileto simplify output handling and standardize naming conventions. The main changes focus on removing the separate Rust build directory for JS samples and ensuring output WASM files have a consistent prefix.Build process simplification and output standardization:
samples/build/rustdirectory for JS sample builds; now only thesamples/build/jsdirectory is used. [1] [2]js-prefix (configurable viaJS_WASM_PREFIX) to all built WASM-JS sample filenames to ensure consistent naming. [1] [2]