-
Notifications
You must be signed in to change notification settings - Fork 980
feat(Topology/Separation/NotNormal): generalize to non-separable spaces #33414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
peakpoint
commented
Dec 30, 2025
PR summary cfceff4198
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Topology.Separation.NotNormal | 1421 | 660 | -761 (-53.55%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Topology.Separation.NotNormal |
-761 |
Declarations diff
+ mk_lt_continuum
+ mk_lt_two_pow_mk_dense
+ not_normal_of_continuum_le_mk
+ not_normal_of_mk_two_pow_dense_le_mk_two_pow
+ not_normal_of_two_pow_mk_dense_le_mk
+ two_pow_mk_le_two_pow_mk_dense
+ two_pow_mk_lt_continuum
- IsClosed.mk_lt_continuum
- IsClosed.not_normal_of_continuum_le_mk
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
ocfnash
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
One optional suggestion to trim some lemmas.
bors d+
|
|
||
| theorem not_normal_of_mk_two_pow_dense_le_mk_two_pow {s d : Set X} (hs : IsClosed s) | ||
| [DiscreteTopology s] (hd : Dense d) (hds : (2 : Cardinal) ^ #d < 2 ^ #s) : ¬NormalSpace X := | ||
| fun _ ↦ (hs.two_pow_mk_le_two_pow_mk_dense hd).not_gt hds | ||
|
|
||
| theorem not_normal_of_two_pow_mk_dense_le_mk {s d : Set X} (hs : IsClosed s) | ||
| [DiscreteTopology s] (hd : Dense d) (hds : 2 ^ #d ≤ #s) : ¬NormalSpace X := | ||
| fun _ ↦ (hs.mk_lt_two_pow_mk_dense hd).not_ge hds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you need these for an application, I wouldn't bother adding these:
| theorem not_normal_of_mk_two_pow_dense_le_mk_two_pow {s d : Set X} (hs : IsClosed s) | |
| [DiscreteTopology s] (hd : Dense d) (hds : (2 : Cardinal) ^ #d < 2 ^ #s) : ¬NormalSpace X := | |
| fun _ ↦ (hs.two_pow_mk_le_two_pow_mk_dense hd).not_gt hds | |
| theorem not_normal_of_two_pow_mk_dense_le_mk {s d : Set X} (hs : IsClosed s) | |
| [DiscreteTopology s] (hd : Dense d) (hds : 2 ^ #d ≤ #s) : ¬NormalSpace X := | |
| fun _ ↦ (hs.mk_lt_two_pow_mk_dense hd).not_ge hds |
(I'm even a bit dubious about mk_lt_two_pow_mk_dense, though I do think it's worth having.)
|
✌️ peakpoint can now approve this pull request. To approve and merge a pull request, simply reply with |