Skip to content

Conversation

@themathqueen
Copy link
Collaborator

@themathqueen themathqueen commented Dec 30, 2025

No code changed: literally just move.


Open in Gitpod

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Dec 30, 2025
@github-actions
Copy link

github-actions bot commented Dec 30, 2025

PR summary a36c84ab82

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@themathqueen themathqueen changed the title chore(Algebra): move LinearMap.mul{Left, Right} to earlier file chore(Algebra): move LinearMap.mul{Left, Right, LeftRight} to earlier file Dec 30, 2025
@Ruben-VandeVelde
Copy link
Collaborator

Can you please split this PR into one that makes the changes in place and one that moves the code unchanged?

@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 30, 2025
@themathqueen
Copy link
Collaborator Author

Can you please split this PR into one that makes the changes in place and one that moves the code unchanged?

Sure, should I also revert the renames?

@themathqueen themathqueen removed the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 31, 2025
@grunweg
Copy link
Collaborator

grunweg commented Dec 31, 2025

Please make the renames a separate change from the code movement, yes. (It's much easier to review this way.)

@themathqueen themathqueen added the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 31, 2025
@themathqueen themathqueen removed the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 31, 2025
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 5, 2026
mathlib-bors bot pushed a commit that referenced this pull request Jan 5, 2026
…er file (#33405)

No code changed: literally just move.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 5, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Algebra): move LinearMap.mul{Left, Right, LeftRight} to earlier file [Merged by Bors] - chore(Algebra): move LinearMap.mul{Left, Right, LeftRight} to earlier file Jan 5, 2026
@mathlib-bors mathlib-bors bot closed this Jan 5, 2026
@themathqueen themathqueen deleted the mv_mulLeft branch January 5, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants