Skip to content

Conversation

@dupuisf
Copy link
Contributor

@dupuisf dupuisf commented Dec 30, 2025

This PR adds a few basic lemmas about doubly stochastic matrices.


Open in Gitpod

@github-actions
Copy link

github-actions bot commented Dec 30, 2025

PR summary 69fc0048aa

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ reindex_mem_doublyStochastic
+ reindex_mem_doublyStochastic_iff
+ sum_mulVec_of_mem_doublyStochastic
+ transpose_mem_doublyStochastic
+ transpose_mem_doublyStochastic_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-analysis Analysis (normed *, calculus) label Dec 30, 2025
@dupuisf dupuisf added the WIP Work in progress label Dec 30, 2025
@dupuisf dupuisf removed the WIP Work in progress label Dec 30, 2025
Copy link
Collaborator

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dupuisf can I instead interest you in taking over #28708 so we can get that over the line? Probably cleaning up some of the proofs there would be helpful.

Comment on lines +100 to 102
@[simp, grind .]
lemma permMatrix_mem_doublyStochastic {σ : Equiv.Perm n} :
σ.permMatrix R ∈ doublyStochastic R n := by
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this mean that grind will add a σ.permMatrix R ∈ doublyStochastic R n fact to the context whenever it sees σ : Equiv.Perm n? That seems a bit much to me, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, here's the pattern this generates:

permMatrix_mem_doublyStochastic: [@Membership.mem _ (Submonoid _ _) _ (doublyStochastic #7 #6 #5 #4 #3 #2 #1) (@PEquiv.toMatrix _ _ _ _ _ _ (@Equiv.toPEquiv _ _ #0))]

So it's quite specific, it pretty much needs to see this exact statement.

@j-loreaux j-loreaux added the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author A reviewer has asked the author a question or requested changes. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants