Skip to content

Conversation

@jeetburman
Copy link

This PR addresses issue #602 by renaming the existing red palette to magenta and introducing a new true red palette.

  • Renamed existing red palette to magenta (pinkish-red hues)
  • Created new red palette based on #F91313 (notification error color)
  • Updated palette.ts to use magenta for error backgrounds
  • New red palette provides true red colors for error states

Resolves #602

Notes for Reviewers

This PR fixes #602

The existing red palette contained pinkish-magenta hues (e.g., #ff385c, #FFB3B9). This has been renamed to magenta for semantic accuracy. A new red palette has been created using #F91313 as the base color, which is already used for notification errors and provides true red colors.

Changes are backward compatible - the magenta palette retains all the previous red values, and components using error states now benefit from more accurate red colors.

Signed commits

  • Yes, I signed my commits.

- Renamed existing red palette to magenta (pinkish-red hues)
- Created new red palette based on #F91313 (notification error color)
- Updated palette.ts to use magenta for error backgrounds
- New red palette provides true red colors for error states

Resolves layer5io#602

Signed-off-by: Jeet Burman <jeetburrman@gmail.com>
@jeetburman
Copy link
Author

jeetburman commented Dec 13, 2025

@Rajesh-Nagarajan-11 @leecalcote @nebula-aac , I request a review.

- Changed magenta color values from rose-red to purple-pink shades
- magenta[40] now #E600AC (true magenta) instead of #ff385c (rose-red)
- magenta palette now uses proper purple-pink spectrum
- Addresses reviewer feedback on color accuracy

Signed-off-by: Jeet Burman <jeetburrman@gmail.com>
@jeetburman
Copy link
Author

jeetburman commented Dec 14, 2025

@saurabhraghuvanshii ,
I've updated the magenta palette to proper magenta (purple-pink) shades:

  • magenta[70]: #FFF0FA (was #FFF0F0)
  • magenta[60]: #FFB3E6 (was #FFB3B9)
  • magenta[50]: #FF66CC (was #FF6179)
  • magenta[40]: #E600AC (was #ff385c)
  • magenta[30]: #B30086 (was #B3153D)
  • magenta[20]: #800060 (was #8C0a2F)
  • magenta[10]: #4D0039 (was #660624)

The magenta palette now uses true purple-pink colors instead of rose-red. The red palette remains unchanged with true red colors based on #F91313.

@saurabhraghuvanshii
Copy link
Contributor

@jeetburman check shades here https://maketintsandshades.com/#colors=B32700&hashtag=0&steps=10 and issue is to rename exitsing shades without removing old shades because we are using that shades everywhere so it will break our current setup

@jeetburman
Copy link
Author

@jeetburman check shades here https://maketintsandshades.com/#colors=B32700&hashtag=0&steps=10 and issue is to rename exitsing shades without removing old shades because we are using that shades everywhere so it will break our current setup

@saurabhraghuvanshii , Thank you for the clarification... Just to make sure I understand correctly:

Should I:

Option A:

  1. Keep existing red palette as-is (rose-red colors like #ff385c)
  2. Add NEW magenta palette (true magenta/purple-pink)
  3. Add NEW crimson or trueRed palette (pure red based on #F91313)

Option B:

  1. Rename existing red to rose (keeping all values)
  2. Add NEW magenta palette
  3. Create NEW red palette (pure red based on #F91313)

I want to make sure I don't break existing components that depend on the current rose-red colors!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change the red palette to magenta and add a generic red palette

2 participants