Update Package.swift to support swift-tools-version:5.8#308
Open
pierre-wehbe wants to merge 1 commit intolaunchdarkly:v8from
Open
Update Package.swift to support swift-tools-version:5.8#308pierre-wehbe wants to merge 1 commit intolaunchdarkly:v8from
pierre-wehbe wants to merge 1 commit intolaunchdarkly:v8from
Conversation
Author
|
In case 5.8 is a concern (since it becomes the minimum), I believe keeping 5.2 would still work |
Contributor
|
Hi @pierre-wehbe , thanks for opening this PR. One of our team will take a look to verify this has no adverse effects on our packages. Thank you! |
Contributor
|
HI @pierre-wehbe . We will be releasing support for XCode15 in the near future. During this work, we looked at the swift-tools-version you have proposed. Unfortunately that bump would be too drastic for our customer base at the moment. We are going to be bumping it from 5.2 to 5.3 however. Are you able to have your build process ignore the deprecation? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
swift-tools-version:5.8 have deprecated the use of .package(name:xxx, url:xxx, from:xxx) to .package(url:xxx, from:xxx).
This causes our internal SPM using 5.8 to break
Describe the solution you've provided
Update LD SPM to support 5.8