Fix broken sets #18
Open
Fix broken sets #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwatters
reviewed
Dec 5, 2023
| String rpattern = ""; | ||
| for (String w : splitPattern) { | ||
| if (w.startsWith("<SET>") || w.startsWith("<BOT") || w.startsWith("NAME=")) { | ||
| if (w.startsWith("<SET>") || w.startsWith("</SET>") || w.startsWith("<BOT") || w.startsWith("</BOT>") || w.startsWith("NAME=")) { |
Owner
There was a problem hiding this comment.
should we be case insensitive here? we made changes a while back to be insensitive to case for the xml tags...
Collaborator
Author
There was a problem hiding this comment.
i'm not positive, but its about "generating" xml - so its prolly important to pick a case and stick to it.
Collaborator
Author
There was a problem hiding this comment.
honestly, i didn't follow all the logic, just saw that end tag matching wasn't complete so 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated set data when appened to would create mis matched tags
this fixes the xml created