-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat: VPA InPlace updateMode #8888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: omerap12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
|
This is a draft since we need the AEP to be merged first. |
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
vertical-pod-autoscaler/pkg/updater/restriction/pods_inplace_restriction.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
|
I plan to review this PR more thoroughly after the AEP is merged into main, but let me add one more comment: I would like to see an e2e test that covers the case described in the AEP:
For example, by starting another large pod, then attempting to update the first pod, observing the failure, and finally killing the large pod, then the in-place update should succeed in the next updater loop. |
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
What type of PR is this?
/kind feature
What this PR does / why we need it:
VPA InPlace updateMode support.
Which issue(s) this PR fixes:
Fixes #8720
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: