Standardize inferencepool Helm templates and drop unnecessary tpl

[tsj-30]

/kind cleanup

What this PR does / why we need it:
Standardizes the Helm template syntax within the inferencepool chart so every toYaml invocation uses the same pipeline style and we avoid unnecessary tpl calls. This makes the templates easier to read, review, and maintain while keeping the rendered manifests identical.

Which issue(s) this PR fixes:
Fixes #1983

Does this PR introduce a user-facing change?:

NONE

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tsj-30
Once this PR has been reviewed and has the lgtm label, please assign danehans for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @tsj-30!

It looks like this is your first PR to kubernetes-sigs/gateway-api-inference-extension 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api-inference-extension has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @tsj-30. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for gateway-api-inference-extension ready!

Name	Link
🔨 Latest commit	ce0372b
🔍 Latest deploy log	https://app.netlify.com/projects/gateway-api-inference-extension/deploys/694053d7fd9a88000863d34a
😎 Deploy Preview	https://deploy-preview-1989--gateway-api-inference-extension.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[tsj-30]

Hey, @nirrozenbaum
Could you PTAL? Let me know if this is ok?
Thanks 😄

[tsj-30]

Hi @kfswain , @shmuelk
Could PTAL, and lmk if this fixed #1983?
Thanks :)

[shmuelk]

/ok-to-test

[shmuelk]

/retest pull-gateway-api-inference-extension-test-unit-main

[k8s-ci-robot]

@shmuelk: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test pull-gateway-api-inference-extension-test-e2e-main

/test pull-gateway-api-inference-extension-test-unit-main

/test pull-gateway-api-inference-extension-verify-main

Use /test all to run all jobs.

Details

In response to this:

/retest pull-gateway-api-inference-extension-test-unit-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[shmuelk]

/test pull-gateway-api-inference-extension-test-unit-main

[nirrozenbaum]

can we use the same pattern of epp cmd-line args?
see here (there it is called flags, but you can keep in your PR the use of the term args, I'm trying to scope this PR to helm chart standartization):

gateway-api-inference-extension/config/charts/inferencepool/templates/epp-deployment.yaml

Lines 100 to 103 in 0f0dff6

	{{- range $key, $value := .Values.inferenceExtension.flags }}
	- --{{ $key }}
	- "{{ $value }}"
	{{- end }}

there are few more places in the yaml file that could be written using the same pattern

[nirrozenbaum]

I believe it terms of readability, the above pattern makes the templates easier for understanding and keeping it very simple.

[kfswain]

++ to Nir's comments, so long as that works here. Not sure if this needs to support env vars also, but perhaps we decompose that to something else anyways, so we can keep consistency with EPP container config