Skip to content

bump K8s min version to 1.33 #3312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow merged 1 commit into from
Jan 20, 2026
Merged

bump K8s min version to 1.33 #3312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion version/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const (
// NOTE: If you are changing this line, please also update the minimum kubernetes
// version listed here:
// https://github.com/knative/docs/blob/main/docs/snippets/prerequisites.md
defaultMinimumVersion = "v1.32.0"
defaultMinimumVersion = "v1.33.0"
)

func getMinimumVersion() string {
Expand Down
16 changes: 8 additions & 8 deletions version/version_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,16 @@ func TestVersionCheck(t *testing.T) {
wantError bool
}{{
name: "greater version (patch)",
actualVersion: &testVersioner{version: "v1.32.1"},
actualVersion: &testVersioner{version: "v1.33.1"},
}, {
name: "greater version (patch), no v",
actualVersion: &testVersioner{version: "1.32.1"},
actualVersion: &testVersioner{version: "1.33.1"},
}, {
name: "greater version (patch), pre-release",
actualVersion: &testVersioner{version: "1.32.1-kpn-065dce"},
actualVersion: &testVersioner{version: "1.33.1-kpn-065dce"},
}, {
name: "greater version (patch), pre-release with build",
actualVersion: &testVersioner{version: "1.32.1-1095+9689d22dc3121e-dirty"},
actualVersion: &testVersioner{version: "1.33.1-1095+9689d22dc3121e-dirty"},
}, {
name: "greater version (patch), pre-release, envvar override",
actualVersion: &testVersioner{version: "1.15.11-kpn-065dce"},
Expand All @@ -60,16 +60,16 @@ func TestVersionCheck(t *testing.T) {
versionOverride: "1.15.11-0",
}, {
name: "greater version (minor)",
actualVersion: &testVersioner{version: "v1.33.0"},
actualVersion: &testVersioner{version: "v1.34.0"},
}, {
name: "same version",
actualVersion: &testVersioner{version: "v1.32.0"},
actualVersion: &testVersioner{version: "v1.33.0"},
}, {
name: "same version with build",
actualVersion: &testVersioner{version: "v1.32.0+k3s.1"},
actualVersion: &testVersioner{version: "v1.33.0+k3s.1"},
}, {
name: "same version with pre-release",
actualVersion: &testVersioner{version: "v1.32.0-k3s.1"},
actualVersion: &testVersioner{version: "v1.33.0-k3s.1"},
}, {
name: "smaller version",
actualVersion: &testVersioner{version: "v1.14.3"},
Expand Down
Loading