forked from supertuxkart/stk-code
-
Notifications
You must be signed in to change notification settings - Fork 6
Initial port of ItemPolicy #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Nomagno
wants to merge
10
commits into
kimden:master
Choose a base branch
from
Nomagno:kimden-itempolicy
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ItemPolicy is a system for determining the rules of a race, as pertaining to which collectibles can spawn, and several types of automatic item "dispensation" upon pass by the start/finish line
- It also includes a system to forbid lappings and lappers from hitting each other, and a virtual pace car/virtual safety car system
- It allows to set different rules for different sections of a race, each section defined by the lap its start
- The current implementation is adapted from STK TME to STK 1.0+command manager, hence only doing the server side business
- Known current issues as of initial implementation commit:
- - IMPORTANT: in the current implementation, each collectible "voluntarily despawns itself" after checking the current itempolicy section in its ::update(). This needs to be force synced to the client
somehow in 1.0. for item boxes and nitro, this doesn't cause basically any lag even if it's strange, but for bananas it does cause lag so it should be fixed BEFORE MERGING.
- - a pit stop slowdown is applied in TME when a virtual pace car restart is underway. This penalty type doesn't exist in 1.0, so it's replaced with a bubblegum slowdown.
However, it's not really synced properly even though it should be synced properly. The slowdown is slow enough it doesn't cause any serious lag, so fine for now.
kimden
requested changes
Aug 23, 2025
Owner
kimden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly stylistic comments and things I noticed without opening IDE
Nomagno
added a commit
to Nomagno/stk-code
that referenced
this pull request
Aug 23, 2025
Owner
|
Please adhere to code style. |
Nomagno
added a commit
to Nomagno/stk-code
that referenced
this pull request
Sep 14, 2025
matahina
pushed a commit
to matahina/stk-code-emt-fixed
that referenced
this pull request
Sep 21, 2025
matahina
pushed a commit
to matahina/stk-code-emt-fixed
that referenced
this pull request
Sep 21, 2025
... + Fix little technical issue lingering from old kimden backport (cherry picked from commit 4d229c0)
Nomagno
added a commit
to Nomagno/stk-code
that referenced
this pull request
Oct 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agreement