Skip to content

Conversation

@alinemorelli
Copy link

Bug Fix

What Is the Current Behavior?

The parameter project for the create-release job just works with default value (SENTRY_PROJECT).

Steps to Reproduce

Set your .circleci/config.yml:

- sentry-cli/create-release:
          context: sentry-org
          project: SENTRY_PROJECT_NAME

Run your job and you will see that parameters.project still using SENTRY_PROJECT, that is the default value.

What Is the Expected Behavior?

When project parameter is filled it should use the new value instead of SENTRY_PROJECT

Additional Context

It is related to this issue: #27

I'm working on a monorepo that have multiple projects, and this is why I need to change the var name used to create releases.

To fix it I'm just binding the project parameter when create-release is called create-release.

@alinemorelli
Copy link
Author

@keimlink I created another branch but looks like it still not being built 😥

@keimlink keimlink self-assigned this Sep 10, 2020
@keimlink keimlink self-requested a review September 10, 2020 08:39
@keimlink
Copy link
Owner

@alinemorelli Thank you for creating another pull request. 🙏

I'm sorry that CircleCI still isn't building your branch. I'll create a fork and check this myself by creating a pull request. 🧐

@keimlink
Copy link
Owner

@alinemorelli I forked the repository and created #48 to add additional parameters to jobs. The branch has been built on CircleCI.

This is a quote from CircleCI's documentation for Building Open Source Projects:

If a user submits a pull request to your repository from a fork, but no pipeline is triggered, then the user most likely is following a project fork on their personal account rather than the project itself of CircleCi, causing the jobs to trigger under the user’s personal account and not the organization account. To resolve this issue, have the user unfollow their fork of the project on CircleCI and instead follow the source project. This will trigger their jobs to run under the organization when they submit pull requests.

Maybe this is the reason why your pull request is not build? 🤔

  1. Please got to your project list on CircleCI and check if you follow the sentry-cli-orb project. If you do, please unfollow it.
  2. Please visit also PicturePipe's project list on CircleCI and check if you're following the sentry-cli-orb project. If not, please follow it.

Hopefully this will make CircleCI build your pull request! 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants