-
Notifications
You must be signed in to change notification settings - Fork 403
GO ADK declarative image #1284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
GO ADK declarative image #1284
Conversation
Signed-off-by: Yaniv Marom Nachumi <yanivmar@amdocs.com>
Signed-off-by: Yaniv Marom Nachumi <yanivmar@amdocs.com>
Signed-off-by: Yaniv Marom Nachumi <yanivmar@amdocs.com>
Signed-off-by: Yaniv Marom Nachumi <yanivmar@amdocs.com>
Signed-off-by: Yaniv Marom Nachumi <yanivmar@amdocs.com>
Signed-off-by: Yaniv Marom Nachumi <yanivmar@amdocs.com>
Signed-off-by: Yaniv Marom Nachumi <yanivmar@amdocs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request introduces a Go-based implementation of the Agent Development Kit (ADK) for Kagent, enabling declarative agent images with support for Azure OpenAI and Anthropic models. The implementation maintains parity with the existing Python-based ADK while providing a native Go alternative.
Changes:
- Adds comprehensive Go ADK implementation in
go-adk/directory with core utilities, skills management, and LLM model adapters - Introduces CRD schema updates to support custom image overrides via
spec.imagefield - Implements build infrastructure for the Go ADK container image (
app-go)
Reviewed changes
Copilot reviewed 59 out of 61 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
go-adk/pkg/core/*.go |
Core package with shared types, session management, task storage, event conversion, and HITL utilities |
go-adk/pkg/adk/*.go |
ADK integration layer for Google ADK compatibility, event conversion, and config loading |
go-adk/pkg/adk/models/*.go |
LLM model implementations for OpenAI, Azure OpenAI, and Anthropic |
go-adk/pkg/skills/*.go |
Skills discovery and shell execution utilities for file operations and command execution |
go-adk/Dockerfile |
Multi-stage build for Go ADK container image |
go-adk/Makefile |
Build and test automation for Go modules |
Makefile |
Root Makefile updates for building app-go image with proxy support |
helm/kagent-crds/templates/kagent.dev_agents.yaml |
CRD updates adding image field with documentation |
go/config/crd/bases/kagent.dev_agents.yaml |
CRD base updates for image override support |
go/api/v1alpha2/agent_types.go |
Go API types updated with Image field for deployment spec |
go/internal/controller/translator/agent/adk_api_translator.go |
Controller logic to use custom image when specified |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
go-adk directory maintained separately until community approval.
Tested AzureOpenIA and Anthropic Models.