fix #1188

[weiyuanke]

#1188

[jcnsjr]

Hey folks! Any updates on this fix? I’m trying to install the latest release (0.7.13) and I’m still running into the same issue. 😕

[weiyuanke]

Hey folks! Any updates on this fix? I’m trying to install the latest release (0.7.13) and I’m still running into the same issue. 😕

oci artifacts seems ok,
oci://ghcr.io/kagent-dev/kagent/helm/kagent 0.7.8
@jcnsjr

[jcnsjr]

Hi @weiyuanke, Im having the same issue you are having but with the newest release:

e.g., ServiceAccount "kagent-kagent-controller" is invalid: metadata.labels: Invalid value: "0.7.13+6030c268d3c0": a valid label must be an empty string or consist of alpha │
│ numeric characters, '-', '' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue', or 'my_value', or '12345', regex used for validation is '(([A-Za-z0-9 │
│ ][-A-Za-z0-9.]*)?[A-Za-z0-9])?') │

Im trying to see if the code owners have any news or schedule to merge your fix or something similar.

ps: Im using Flux, and Flux CRD OCIRepository appends build metadata (short SHA256 digest) to Helm chart versions, so a tag like 0.7.13 becomes 0.7.13+6030c268d3c0 and ends up as .Chart.Version.

[EItanya]

I am able to install as well, so this must specifically be related to flux. Can you send some examples of other projects which are working. I just checked another project which I am a maintainer on and we don't have it there either: https://github.com/kgateway-dev/kgateway/blob/92b65d62d40e4e4388e97ceaae42d2638a66e97d/install/helm/agentgateway/templates/_helpers.tpl#L40

[jcnsjr]

Yes, this is Flux-specific.

The agentgateway chart sets: app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}

but this chart sets: app.kubernetes.io/version: {{ .Chart.Version | quote }}

The pattern used in the agentgateway chart is to:

• keep the chart package version in helm.sh/chart (via a helper/named template), and
• use .Chart.AppVersion for app.kubernetes.io/version.

Example from agentgateway (_helpers.tpl):

{{- define "agentgateway.chart" -}}
{{- printf "%s-%s" .Chart.Name .Chart.Version | replace "+" "_" | trunc 63 | trimSuffix "-" -}}
{{- end }}

{{- define "agentgateway.labels" -}}
helm.sh/chart: {{ include "agentgateway.chart" . }}
{{ include "agentgateway.selectorLabels" . }}
{{- if .Chart.AppVersion }}
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
{{- end }}
app.kubernetes.io/managed-by: {{ .Release.Service }}
{{- with .Values.commonLabels | default dict }}
{{ toYaml . }}
{{- end }}
{{- end }}

So a simpler fix might be to just follow the pattern of using AppVersion instead of Version.

I have kgateway on my cluster, which uses the same fix/pattern as agentgateway so this is what the labels look like:

Labels: app.kubernetes.io/instance=kgateway-system-kgateway
app.kubernetes.io/managed-by=Helm
app.kubernetes.io/name=kgateway
app.kubernetes.io/version=1.16.0
helm.sh/chart=kgateway-2.1.1_0c2bb8ac869b
helm.toolkit.fluxcd.io/name=kgateway
helm.toolkit.fluxcd.io/namespace=flux-system
kgateway=kgateway

[EItanya]

That makes sense to me