Add metadata to server controller #630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add metadata field to server controller allowing setting metadata on servers created by orc
winiciusallan
approved these changes
Jan 9, 2026
Contributor
winiciusallan
left a comment
winiciusallan
left a comment
There was a problem hiding this comment.
Bullseye 🎯
Just a small question to check if I understood correctly. Why do we need reconcileMetadata exactly? Can't we create it and update it on updateResource?
Collaborator
We're using a different reconcile function because, while we could add metadata at server creation, the server update and the metadata update are two different API calls, and it's easier to ensure atomicity and idempotency this way. |
mandre
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metadata support