-
Notifications
You must be signed in to change notification settings - Fork 34
Add Trunk resource controller implementation #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aldokimi
wants to merge
11
commits into
k-orc:main
Choose a base branch
from
aldokimi:dev/trunk_type
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7c84bf2
Trunk resource: add Trunk resource controller implementation
aldokimi 6150f8c
Trunk resource: auto-generated files + fixing some bugs
aldokimi 1acb6e5
Trunk resource: increase test coverage + fix bugs
aldokimi 81998d1
Trunk resource: add improvments + fix bugs
aldokimi c81b739
Trunk resource: fixed testing
aldokimi af0d4a5
Trunk type: fix scaffolding issues + minor bugs
aldokimi a8d9fbc
Trunk type: Added tags reconsiling + fix some bugs
aldokimi 7d6bd28
Trunk type: Added subports list reconsiling
aldokimi b723cdf
Trunk type: fix PortRef pointer problem
aldokimi 82e2ff6
Trunk type: fixed finalizer issue + minor bugs
aldokimi 9e54e53
Trunk type: fixed CI testing issues
aldokimi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,179 @@ | ||
| /* | ||
| Copyright 2025 The ORC Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package v1alpha1 | ||
|
|
||
| // TrunkSubportSpec represents a subport to attach to a trunk. | ||
| // It maps to gophercloud's trunks.Subport. | ||
| type TrunkSubportSpec struct { | ||
| // portRef is a reference to the ORC Port that will be attached as a subport. | ||
| // +required | ||
| PortRef KubernetesNameRef `json:"portRef,omitempty"` | ||
|
|
||
| // segmentationID is the segmentation ID for the subport (e.g. VLAN ID). | ||
| // +required | ||
| // +kubebuilder:validation:Minimum:=1 | ||
| // +kubebuilder:validation:Maximum:=4094 | ||
| SegmentationID int32 `json:"segmentationID,omitempty"` | ||
|
|
||
| // segmentationType is the segmentation type for the subport (e.g. vlan). | ||
| // +required | ||
| // +kubebuilder:validation:MinLength:=1 | ||
| // +kubebuilder:validation:MaxLength:=32 | ||
| // +kubebuilder:validation:Enum:=inherit;vlan | ||
| SegmentationType string `json:"segmentationType,omitempty"` | ||
| } | ||
|
|
||
| // TrunkSubportStatus represents an attached subport on a trunk. | ||
| // It maps to gophercloud's trunks.Subport. | ||
| type TrunkSubportStatus struct { | ||
| // portID is the OpenStack ID of the Port attached as a subport. | ||
| // +kubebuilder:validation:MaxLength=1024 | ||
| // +optional | ||
| PortID string `json:"portID,omitempty"` | ||
|
|
||
| // segmentationID is the segmentation ID for the subport (e.g. VLAN ID). | ||
| // +optional | ||
| SegmentationID int32 `json:"segmentationID,omitempty"` | ||
|
|
||
| // segmentationType is the segmentation type for the subport (e.g. vlan). | ||
| // +kubebuilder:validation:MaxLength=1024 | ||
| // +optional | ||
| SegmentationType string `json:"segmentationType,omitempty"` | ||
| } | ||
|
|
||
| // TrunkResourceSpec contains the desired state of the resource. | ||
| type TrunkResourceSpec struct { | ||
| // name will be the name of the created resource. If not specified, the | ||
| // name of the ORC object will be used. | ||
| // +optional | ||
| Name *OpenStackName `json:"name,omitempty"` | ||
|
|
||
| // description is a human-readable description for the resource. | ||
| // +optional | ||
| Description *NeutronDescription `json:"description,omitempty"` | ||
|
|
||
| // portRef is a reference to the ORC Port which this resource is associated with. | ||
| // +required | ||
| // +kubebuilder:validation:XValidation:rule="self == oldSelf",message="portRef is immutable" | ||
| PortRef KubernetesNameRef `json:"portRef,omitempty"` | ||
|
|
||
| // projectRef is a reference to the ORC Project which this resource is associated with. | ||
| // +optional | ||
| // +kubebuilder:validation:XValidation:rule="self == oldSelf",message="projectRef is immutable" | ||
| ProjectRef *KubernetesNameRef `json:"projectRef,omitempty"` | ||
|
|
||
| // adminStateUp is the administrative state of the trunk. If false (down), | ||
| // the trunk does not forward packets. | ||
| // +optional | ||
| AdminStateUp *bool `json:"adminStateUp,omitempty"` | ||
|
|
||
| // subports is the list of ports to attach to the trunk. | ||
| // +optional | ||
| // +kubebuilder:validation:MaxItems:=1024 | ||
| // +listType=atomic | ||
| Subports []TrunkSubportSpec `json:"subports,omitempty"` | ||
|
|
||
| // tags is a list of Neutron tags to apply to the trunk. | ||
| // +kubebuilder:validation:MaxItems:=64 | ||
| // +listType=set | ||
| // +optional | ||
| Tags []NeutronTag `json:"tags,omitempty"` | ||
| } | ||
|
|
||
| // TrunkFilter defines an existing resource by its properties | ||
| // +kubebuilder:validation:MinProperties:=1 | ||
| type TrunkFilter struct { | ||
| // name of the existing resource | ||
| // +optional | ||
| Name *OpenStackName `json:"name,omitempty"` | ||
|
|
||
| // description of the existing resource | ||
| // +optional | ||
| Description *NeutronDescription `json:"description,omitempty"` | ||
|
|
||
| // portRef is a reference to the ORC Port which this resource is associated with. | ||
| // +optional | ||
| PortRef *KubernetesNameRef `json:"portRef,omitempty"` | ||
|
|
||
| // projectRef is a reference to the ORC Project which this resource is associated with. | ||
| // +optional | ||
| ProjectRef *KubernetesNameRef `json:"projectRef,omitempty"` | ||
|
|
||
| // status indicates whether the trunk is currently operational. Possible values include | ||
| // `ACTIVE', `DOWN', `BUILD', `DEGRADED' or `ERROR'. Plug-ins might define additional values. | ||
| // +optional | ||
| // +kubebuilder:validation:MaxLength:=1024 | ||
| Status *string `json:"status,omitempty"` | ||
|
|
||
| // adminStateUp is the administrative state of the trunk. | ||
| // +optional | ||
| AdminStateUp *bool `json:"adminStateUp,omitempty"` | ||
|
|
||
| FilterByNeutronTags `json:",inline"` | ||
| } | ||
|
|
||
| // TrunkResourceStatus represents the observed state of the resource. | ||
| type TrunkResourceStatus struct { | ||
| // name is a Human-readable name for the resource. Might not be unique. | ||
| // +kubebuilder:validation:MaxLength=1024 | ||
| // +optional | ||
| Name string `json:"name,omitempty"` | ||
|
|
||
| // description is a human-readable description for the resource. | ||
| // +kubebuilder:validation:MaxLength=1024 | ||
| // +optional | ||
| Description string `json:"description,omitempty"` | ||
|
|
||
| // portID is the ID of the Port to which the resource is associated. | ||
| // +kubebuilder:validation:MaxLength=1024 | ||
| // +optional | ||
| PortID string `json:"portID,omitempty"` | ||
|
|
||
| // projectID is the ID of the Project to which the resource is associated. | ||
| // +kubebuilder:validation:MaxLength=1024 | ||
| // +optional | ||
| ProjectID string `json:"projectID,omitempty"` | ||
|
|
||
| // tenantID is the project owner of the trunk (alias of projectID in some deployments). | ||
| // +kubebuilder:validation:MaxLength=1024 | ||
| // +optional | ||
| TenantID string `json:"tenantID,omitempty"` | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Although |
||
|
|
||
| // status indicates whether the trunk is currently operational. | ||
| // +kubebuilder:validation:MaxLength=1024 | ||
| // +optional | ||
| Status string `json:"status,omitempty"` | ||
|
|
||
| // tags is the list of tags on the resource. | ||
| // +kubebuilder:validation:MaxItems=64 | ||
| // +kubebuilder:validation:items:MaxLength=1024 | ||
| // +listType=atomic | ||
| // +optional | ||
| Tags []string `json:"tags,omitempty"` | ||
|
|
||
| NeutronStatusMetadata `json:",inline"` | ||
|
|
||
| // adminStateUp is the administrative state of the trunk. | ||
| // +optional | ||
| AdminStateUp *bool `json:"adminStateUp,omitempty"` | ||
|
|
||
| // subports is a list of ports associated with the trunk. | ||
| // +kubebuilder:validation:MaxItems=1024 | ||
| // +listType=atomic | ||
| // +optional | ||
| Subports []TrunkSubportStatus `json:"subports,omitempty"` | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please set a maximum length here?
When you don't specify, CEL works by calculating the worst case for that validation, so we always try to set this value, even if it is an estimate. Here it is a talk that explore more about it (thanks Martin).