chore: update some parts of the pre-commit #1093
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
commented
Dec 12, 2025
Comment on lines
-33
to
+34
| - repo: https://github.com/pre-commit/mirrors-prettier | ||
| rev: "v4.0.0-alpha.8" | ||
| - repo: https://github.com/rbubley/mirrors-prettier | ||
| rev: "v3.7.3" |
Contributor
Author
There was a problem hiding this comment.
The pre-commit mirror was shutdown; this is a maintained replacement.
henryiii
commented
Dec 12, 2025
| rev: v0.14.0 | ||
| hooks: | ||
| - id: ruff-check | ||
| types_or: [python, jupyter] |
Contributor
Author
There was a problem hiding this comment.
This is now the default (along with .pyi), jupyter was added a while ago.
henryiii
commented
Dec 12, 2025
| rev: "2025.10.01" | ||
| hooks: | ||
| - id: sp-repo-review | ||
| additional_dependencies: ["repo-review[cli]"] |
Contributor
Author
There was a problem hiding this comment.
This is only needed if you add extra dependencies.
henryiii
commented
Dec 12, 2025
Comment on lines
45
to
56
| args: ["--install-types", "--non-interactive"] | ||
| args: [] | ||
| additional_dependencies: | ||
| ["traitlets>=5.13", "ipykernel>=6.26", "jupyter_core>=5.3.2"] | ||
| - traitlets>=5.13 | ||
| - ipykernel>=6.26 | ||
| - jupyter_core>=5.3.2 | ||
| - types-pexpect | ||
| - types-paramiko | ||
| - types-netifaces | ||
| - types-psutil | ||
| - types-python-dateutil |
Contributor
Author
There was a problem hiding this comment.
This enables prek to work, since it doesn't have pip installed, and mypy assumes pip is available to install things. And it's faster.
Member
|
Awesome thank you. I did merge in #1064 so if you're able to rebase to put your changes in please do. |
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
henryiii
force-pushed
the
henryiii/chore/precommitup
branch
from
e023feb to
e3cd645
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1064 (will conflict a little with that one).
This also works properly with
prek, a faster Rust pre-commit tool (no pip present for mypy install types).