Simplify with MatrixOfConstraints #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blegat
force-pushed
the
bl/matrix_of_constraints
branch
from
e4fd44f to
062cc1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package defines new struct and implement the MOI API for them. We still haven't released this package because we know there are many more combination to add and we don't want to maintain all these and make them efficient.
We've made the effort to make
MatrixOfConstraintsefficient and we make an effort for most of the solver wrapper to useMatrixOfConstraints.So I think a better approach for this package is not to define new struct but just add simple functions that make it easy to create the right
MatrixOfConstraintsinstance.Note that if this
MatrixOfConstraintsinstance exactly match the one needed by solver, we may even have an even lightercopy_to, at the moment it will probably not happen since they as for the mutable sparse matrices but the solvers could in theory relax that if at some point we find it useful. It's nice that this is in theory possible but probably not high priority.For conic, we can do what suggested in #32 (comment).