-
-
Notifications
You must be signed in to change notification settings - Fork 408
fix: changed the code blocks (JsonEditor) to look light on light theme mode #2139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @VIDIT45AGARWAL! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: completed checklist items Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2139 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 640 649 +9
Branches 198 204 +6
=========================================
+ Hits 640 649 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Utkarsh-123github
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @VIDIT45AGARWAL , in your PR, tests are failing, please fix that.
Thanks!
|
Hi @Utkarsh-123github , thanks for letting me know. |
d853183 to
b8bd164
Compare
|
Hey @Utkarsh-123github , now all checks have been passed. Please review the PR whenever you have a moment. |
|
Also @Utkarsh-123github , if you are free please re-review this PR too. |
What kind of change does this PR introduce?
BugFix : Fixed light theme support for JSON editor and GettingStarted components
Issue Number:
Closes #2127
Screenshots/videos:
Current View :

Fixed View :

If relevant, did you update the documentation?
No
Summary
This PR fixes light theme support for two key components:
1) JsonEditor Component:
Previously only supported dark theme styling. Now properly switches between light and dark themes with appropriate colors for text, backgrounds, borders, and syntax highlighting.
2) GettingStarted Component:
Added full light theme support with proper color contrast, theme-aware syntax highlighting, and improved UI elements.
3) Improved Test Stability:
Updated Cypress tests to use dedicated data-test attributes instead of theme-dependent CSS selectors. This prevents test failures during theme changes and makes tests more maintainable by separating styling concerns from test logic.
Key Changes:
Does this PR introduce a breaking change?
No
Checklist
Please ensure the following tasks are completed before submitting this pull request.