Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances meeting URL extraction from Google Calendar events to support scheme-less URLs (e.g., "zoom.us/j/12345") and HTML-escaped text. The key improvements enable the bot to join more meetings by detecting meeting links in various formats.
- Adds support for extracting scheme-less meeting URLs (e.g., "zoom.us/j/12345") by prepending "https://"
- Implements HTML unescaping for calendar event fields to handle HTML-encoded content
- Restructures meeting URL extraction logic with better fallback handling and source tracking
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| attendee/bots/tasks/sync_calendar_task.py | Enhanced extract_meeting_url_from_text to handle scheme-less URLs and HTML-escaped content; refactored _remote_event_to_calendar_event_data for better URL extraction with source tracking |
| Bot/app/api/meetings.py | Duplicates meeting URL extraction logic from sync_calendar_task with HTML unescaping and scheme-less URL support |
| Bot/Dockerfile | Reduces uvicorn workers from 4 to 1 |
Comments suppressed due to low confidence (2)
attendee/bots/tasks/sync_calendar_task.py:1
- The test
test_scheme_less_urlexpects scheme-less URLs to returnNone, but the new implementation now handles scheme-less patterns and returns a valid URL. This test will fail and needs to be updated to expect a valid URL likehttps://zoom.us/j/123456789instead ofNone.
import copy
attendee/bots/tasks/sync_calendar_task.py:1
- The test
test_mixed_case_scheme_and_hostexpects mixed-case URLs to returnNone, but with the newre.IGNORECASEflag onURL_CANDIDATE, this should now successfully match and return a URL. This test needs to be updated to reflect the new behavior.
import copy
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.