Implement Contribution Service by VishakhaSainani-Josh · Pull Request #13 · joshsoftware/code-curiosity-2025

VishakhaSainani-Josh · 2025-06-09T16:33:11Z

Issue resolved #3

Get all users list from db to query BigQuery for previous day contributions
Fetch contributions from BigQuery
Parse the fetched contribution data
Check if the repository related to the contribution exists
If it does not exist:
Create a new entry in the repositories table
Retrieve the newly created repository ID
Get the user who did that contribution
Get the score to be assigned for the particular contribution type
Insert the contribution into the contributions table using the repository ID

…y service (in future this will be a cron job that will be scheduled to run daily)

pari-27 · 2025-06-16T07:03:24Z

internal/app/contribution/service.go

+
+		repoFetched, err := s.repositoryService.GetRepoByRepoId(ctx, contribution.RepoID)
+		repositoryId := repoFetched.Id
+		if err != nil {


The error must be checked before the assignment

okay, I can put it in else then

pari-27 · 2025-06-16T07:13:08Z

internal/app/contribution/service.go

+	}
+}
+
+func (s *service) ProcessFetchedContributions(ctx context.Context) error {


This method is very big please check if we can we refactor this

pari-27 · 2025-06-16T07:17:14Z

internal/repository/repository.go

+	"github.com/joshsoftware/code-curiosity-2025/internal/pkg/apperrors"
+)
+
+type repositoryRepository struct {


can we have a different name for the struct

We discussed about it, this one works for now as the standard naming kept for db layer is repository and we have a repository table in our system as well. If needed then I can change the repository folder name to dbstore or something else. This will initiate changes in all other parts as well. Let me know if I should.

pari-27 · 2025-06-16T07:18:50Z

internal/app/repository/service.go

+
+	req.Header.Add("Authorization", s.appCfg.GithubPersonalAccessToken)
+
+	client := &http.Client{}


suggesstion -> Pass this in the service struct so that we can reuse it rather than creating a new client everytime

…andling while fetching repositoryDetails

…on-service

…ndled in frontend

Suhaan-Bhandary-Josh · 2025-06-28T14:09:29Z

internal/app/contribution/service.go

+		if err := contributions.Next(&contribution); err == iterator.Done {
+			break
+		} else if err != nil {
+			slog.Error("error iterating contribution rows", "error", err)
+			break
+		}


error is being not returned here, try to refactor this as:

if err != nil { if err == iterator.Done { break } slog.Error("error iterating contribution rows", "error", err) return err }

Suhaan-Bhandary-Josh · 2025-06-28T14:14:37Z

internal/app/contribution/service.go

+
+		var repositoryId int
+		repoFetched, err := s.repositoryService.GetRepoByRepoId(ctx, contribution.RepoID) //err no rows
+		if err != nil {


Explicitly check for apperrors.ErrRepoNotFound

Suhaan-Bhandary-Josh · 2025-06-28T14:15:16Z

internal/app/contribution/service.go

+			repo, err := s.repositoryService.FetchRepositoryDetails(ctx, contribution.RepoUrl)
+			if err != nil {
+				slog.Error("error fetching repository details")
+				return err
+			}
+
+			repositoryCreated, err := s.repositoryService.CreateRepository(ctx, contribution.RepoID, repo)
+			if err != nil {
+				slog.Error("error creating repository", "error", err)
+				return err
+			}
+


move the remove creation logic to another function, to reduce cognitive complexity

Suhaan-Bhandary-Josh · 2025-06-28T14:16:51Z

internal/app/contribution/service.go

+	var action string
+	if actionVal, ok := contributionPayload["action"]; ok {
+		action = actionVal.(string)
+	}


Is it ok if action is empty, do we need to handle it?

action value cannot be empty, according to the events used all those have action as a key in their payload.

Suhaan-Bhandary-Josh · 2025-06-28T14:19:58Z

internal/app/contribution/service.go

+	var contributionType string
+	switch contribution.Type {
+	case "PullRequestEvent":
+		if action == "closed" && isMerged {


create constants for strings

Suhaan-Bhandary-Josh · 2025-06-28T14:24:53Z

internal/app/repository/domain.go

+
+import "time"
+
+type RepoOWner struct {


Suhaan-Bhandary-Josh · 2025-06-28T14:26:16Z

internal/app/repository/service.go

+	resp, err := s.httpClient.Do(req)
+	if err != nil {
+		slog.Error("error fetching user repositories details", "error", err)
+		return FetchRepositoryDetailsResponse{}, err
+	}
+
+	body, err := io.ReadAll(resp.Body)
+	if err != nil {
+		slog.Error("error freading body", "error", err)
+		return FetchRepositoryDetailsResponse{}, err
+	}
+
+	var repoDetails FetchRepositoryDetailsResponse
+	err = json.Unmarshal(body, &repoDetails)
+	if err != nil {
+		slog.Error("error unmarshalling fetch repository details body", "error", err)
+		return FetchRepositoryDetailsResponse{}, err
+	}


Create a utils function to do network calls, eg: DoPost, DoGet and so on

okay. Also I want to move the FetchRepositoryDetails and other functions which are calls to github API's in a separate service named github. So there I can call the utility. Is that fine?

Suhaan-Bhandary-Josh · 2025-06-28T14:29:11Z

internal/app/bigquery/service.go

+	YesterdayDate := time.Now().AddDate(0, 0, -1)
+	YesterdayYearMonthDay := YesterdayDate.Format("20060102")


define variables close to where they are used

Suhaan-Bhandary-Josh · 2025-06-28T14:32:45Z

internal/app/bigquery/service.go

+	fetchDailyContributionsQuery := fmt.Sprintf(` 
+SELECT 
+  id,
+  type,
+  public,
+  actor.id AS actor_id,
+  actor.login AS actor_login,
+  actor.gravatar_id AS actor_gravatar_id,
+  actor.url AS actor_url,
+  actor.avatar_url AS actor_avatar_url,
+  repo.id AS repo_id,
+  repo.name AS repo_name,
+  repo.url AS repo_url,
+  payload,
+  created_at,
+  other
+FROM 
+  githubarchive.day.%s
+WHERE 
+  type IN (
+    'IssuesEvent', 
+    'PullRequestEvent', 
+    'PullRequestReviewEvent', 
+    'IssueCommentEvent', 
+    'PullRequestReviewCommentEvent'
+  )
+  AND (
+    actor.login IN (%s) 
+  )
+`, YesterdayYearMonthDay, githubUsernames)


define the query in a constant or another file

Suhaan-Bhandary-Josh · 2025-06-28T14:35:34Z

internal/repository/contribution.go

+	executer := cr.BaseRepository.initiateQueryExecuter(tx)
+
+	var contribution Contribution
+	err := executer.QueryRowContext(ctx, createContributionQuery,
+		contributionInfo.UserId,
+		contributionInfo.RepositoryId,
+		contributionInfo.ContributionScoreId,
+		contributionInfo.ContributionType,
+		contributionInfo.BalanceChange,
+		contributionInfo.ContributedAt,
+	).Scan(
+		&contribution.Id,
+		&contribution.UserId,
+		&contribution.RepositoryId,
+		&contribution.ContributionScoreId,
+		&contribution.ContributionType,
+		&contribution.BalanceChange,
+		&contribution.ContributedAt,
+		&contribution.CreatedAt,
+		&contribution.UpdatedAt,
+	)
+	if err != nil {
+		slog.Error("error occured while inserting contributions", "error", err)
+		return Contribution{}, apperrors.ErrContributionCreationFailed
+	}
+
+	return contribution, err
+}
+
+func (cr *contributionRepository) GetContributionScoreDetailsByContributionType(ctx context.Context, tx *sqlx.Tx, contributionType string) (ContributionScore, error) {


Need to handle no row error explicitly in this function

… define constants for strings

VishakhaSainani added 6 commits June 5, 2025 15:48

create contribution fetching for all users in the system from bigquer…

3834565

…y service (in future this will be a cron job that will be scheduled to run daily)

Merge branch 'feat/db_migrations' into feat/contribution-service

1c7b715

Merge branch 'fix/login-timestamp-type' into feat/contribution-service

284fdaf

use userid while adding contribution

d3d91a4

get id and score from contribution_score

1c1135f

fix date format

f94000e

VishakhaSainani-Josh requested a review from pari-27 June 12, 2025 15:57

pari-27 reviewed Jun 16, 2025

View reviewed changes

VishakhaSainani added 9 commits June 16, 2025 15:50

refactor processfetchedcontribution function and update http client h…

a17215c

…andling while fetching repositoryDetails

implement users five recent contributions

de13e7a

fetch all contributions for the user

f7e8fa9

remove unnecessary lines

887faa4

pass http client in service struct

bb68dfa

add contributors_url in repository table

e5a4d0b

Merge branch 'db/migration/add-contributors-url' into feat/contributi…

a8e5768

…on-service

fetch and contributors url for repository

5773245

remove fetch five recent contributions for the user- this could be ha…

f365171

…ndled in frontend

VishakhaSainani-Josh requested a review from Suhaan-Bhandary-Josh June 23, 2025 06:33

Suhaan-Bhandary-Josh reviewed Jun 28, 2025

View reviewed changes

VishakhaSainani added 2 commits July 1, 2025 11:52

define contribution fetching query from bigquery as a constant

3ac004e

rename function FetchUsersAllContributions to FetchUserContributions,…

a306776

… define constants for strings


		req.Header.Add("Authorization", s.appCfg.GithubPersonalAccessToken)

		client := &http.Client{}

		YesterdayDate := time.Now().AddDate(0, 0, -1)
		YesterdayYearMonthDay := YesterdayDate.Format("20060102")

Conversation

VishakhaSainani-Josh commented Jun 9, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants