Generate stations.json using the offical MTA station list CSV#26
Open
georgyo wants to merge 1 commit intojonthornton:masterfrom
Open
Generate stations.json using the offical MTA station list CSV#26georgyo wants to merge 1 commit intojonthornton:masterfrom
georgyo wants to merge 1 commit intojonthornton:masterfrom
Conversation
Contributor
Author
|
This is likely not mergeable as is, because WTFT hard codes md5 generated station IDs for defaults, and people's stored favorites also use them. However getting to a consistent state of station IDs across MTA integrations would be useful. |
Owner
|
Thanks for posting this! I agree with both of your points that it'd be an improvement but also a breaking change. I'll need to think about the migration path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MTA does have listing of all stations in their dataset defined as "Station Locations" here
Every station is part of a Complex that can contain other stations. IE
Here you can see that Atlantic Av-Barclays Ctr has 3 rows, and the "Complex ID" is static accross all of them. This makes the station IDs consistent across all other MTA integrations as well.
http://web.mta.info/developers/developer-data-terms.html#data