Add proper support for scrollToItemAtIndexPath:scrollPosition:animated#18
Open
joelekstrom wants to merge 1 commit intomasterfrom
Open
Add proper support for scrollToItemAtIndexPath:scrollPosition:animated#18joelekstrom wants to merge 1 commit intomasterfrom
scrollToItemAtIndexPath:scrollPosition:animated#18joelekstrom wants to merge 1 commit intomasterfrom
Conversation
Handling correct scrolling to items required special handling in this class, since UICollectionView does not expect layouts to have items outside the scrollable bounds. It was solved by swizzling the method and forwarding it to the layout (if the layout is the correct class). Also adds a new public API: - (void)setHorizontalOffset:(CGFloat)offset forSectionAtIndex:(NSUInteger)index animated:(BOOL)animated; This might improve AppleTV support, hopefully fixing the problem described in #17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handling correct scrolling to items required special handling in this
class, since UICollectionView does not expect layouts to have items
outside the scrollable bounds. It was solved by swizzling the method
and forwarding it to the layout (if the layout is the correct class).
Also adds a new public API:
- (void)setHorizontalOffset:(CGFloat)offset forSectionAtIndex:(NSUInteger)index animated:(BOOL)animated;This might improve AppleTV support, hopefully fixing the problem
described in #17