Add simulated Broadlink device for E2E testing by Copilot · Pull Request #76 · jodavis/AdaptiveRemote

Copilot · 2026-01-29T17:57:04Z

Implementation Plan: Simulated Broadlink Device for E2E Testing

Based on the specification in _spec_SimulatedBroadlinkDevice.md, I implemented a simulated Broadlink device following the existing SimulatedTiVo pattern.

Implementation Checklist

Final Status

✅ All requirements met:

Simulated Broadlink device fully functional with complete protocol support
All 3 E2E tests pass (startup/shutdown, TiVo command, Broadlink command)
Build succeeds with zero warnings (/warnaserror)
Code review feedback fully addressed
Architecture improved for better testability and DI support
Documentation updated to stay current with code

Original prompt

This section details on the original issue you should resolve

<issue_title>Create a simulated Broadlink device for E2E tests</issue_title>
<issue_description>Is your feature request related to a problem? Please describe.
End to end tests start the host application with a NullCommandService for Broadlink commands, which means none of the Broadlink support is being tested.

Describe the solution you'd like
Create a simulated Broadlink device, similar to the SimulatedTiVoDevice, which the application can connect to in test scenarios.

Additional context
Follow the specifications and implementation plan in _spec_SimulatedBroadlinkDevice.md (added in PR #74)</issue_description>

<agent_instructions>Implement this feature as described in _spec_SimulatedBroadlinkDevice.md. When complete, the tests should not use --broadlink:Fake, there should be a new test for a Broadlink command, the build should pass without warnings or errors (build with /warnaserror), and all tests should pass, especially the headless E2E tests. When finished, replace _spec_SimulatedBroadlinkDevice.md and _doc_SimulatedTiVoDevice.md with a combined _doc_SimulatedDevices.md that describes the system as implemented.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes Create a simulated Broadlink device for E2E tests #75

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: jodavis <6740581+jodavis@users.noreply.github.com>

…improve documentation Co-authored-by: jodavis <6740581+jodavis@users.noreply.github.com>

github-actions · 2026-01-29T18:35:11Z

Test Results

311 tests +3 305 ✅ +1 1m 8s ⏱️ -44s
5 suites ±0 6 💤 +2
5 files ±0 0 ❌ ±0

Results for commit 0146614. ± Comparison against base commit 6854c1d.

This pull request removes 3 and adds 5 tests. Note that renamed tests count towards both.

,False)
AdaptiveRemote.Services.ProgrammaticSettings.PersistSettingsTests ‑ PersistSettings_Set_ValidatesKeyNameAsync (Hello
AdaptiveRemote.Services.ProgrammaticSettings.PersistSettingsTests ‑ PersistSettings_Set_ValidatesValueAsync (Invalid

AdaptiveRemote.EndToEndTests.ConsoleHost.Features.BroadlinkDeviceIntegrationFeature ‑ Broadlink receives Power command
AdaptiveRemote.EndToEndTests.HeadlessHost.Features.BroadlinkDeviceIntegrationFeature ‑ Broadlink receives Power command
AdaptiveRemote.EndToEndTests.WpfHost.Features.BroadlinkDeviceIntegrationFeature ‑ Broadlink receives Power command
AdaptiveRemote.Services.ProgrammaticSettings.PersistSettingsTests ‑ PersistSettings_Set_ValidatesKeyNameAsync (Hello
,False)
AdaptiveRemote.Services.ProgrammaticSettings.PersistSettingsTests ‑ PersistSettings_Set_ValidatesValueAsync (Invalid
,False)

♻️ This comment has been updated with latest results.

jodavis

@copilot Please make these changes.

jodavis · 2026-01-29T20:41:11Z

test/AdaptiveRemote.EndToEndTests.Steps/BroadlinkSteps.cs

+    [Then(@"I should see the Broadlink device recorded at least one inbound packet")]
+    public void ThenIShouldSeeTheBroadlinkDeviceRecordedAtLeastOneInboundPacket()
+    {
+        ISimulatedBroadlinkDevice? device = Environment.Broadlink;


Ideally there would not be so much logic in the Step implementations themselves. The logic should be in the TestServices assembly, and the step definitions should be about translating and validating steps and parameters. That way if I need to build non-Gherkin tests, all the logic is available.

I'm not sure the best way to handle this. Either the logic could be build directly into the SimulatedBroadlinkDevice itself, or it could be build as extension methods on ISimulatedBroadlinkDevice.

Moved logic to extension methods in ISimulatedBroadlinkDeviceExtensions.cs - HasRecordedInboundPacketWithIrData(), GetRecordedPacketsDebugString(), GetFirstPacketWithIrData(), and GetFirstMalformedPacket(). Step definitions now just call these methods. (7e3b34f)

test/AdaptiveRemote.EndtoEndTests.TestServices/Host/ISimulatedEnvironment.cs

test/AdaptiveRemote.EndtoEndTests.TestServices/Host/SimulatedEnvironment.cs

jodavis · 2026-01-29T20:47:43Z

test/AdaptiveRemote.EndtoEndTests.TestServices/SimulatedBroadlink/ISimulatedBroadlinkDevice.cs

+    /// <summary>
+    /// Gets the actual UDP port the device is bound to (useful when using ephemeral ports).
+    /// </summary>
+    int BoundPort { get; }


Rename to just Port

I see, there is already a Port property because this extends ISimulatedDevice. I wonder what this is for..

Removed BoundPort property. Since ISimulatedBroadlinkDevice extends ISimulatedTiVoDevice (formerly ISimulatedDevice), it inherits the Port property which serves the same purpose. (7e3b34f)

...ptiveRemote.EndtoEndTests.TestServices/SimulatedBroadlink/SimulatedBroadlinkDeviceBuilder.cs

test/AdaptiveRemote.EndToEndTests.Steps/HostSteps.cs

jodavis · 2026-01-29T23:03:38Z

test/AdaptiveRemote.EndtoEndTests.TestServices/_doc_SimulatedDevices.md

+
+### Core Interfaces
+
+```csharp


Instead of including all these code samples, just link to the actual code. That way the documentation won't get out of date.

In general, the documentation should be adding information that's not easily understood from the code. Links to code files can be provided where seeing the code would help with understanding.

I'll update the documentation to link to actual code files instead of embedding code samples.

Updated documentation to link to actual code files instead of embedding samples. Removed all code blocks and replaced with links to implementation files. Added references to test steps, features, and protocol implementation. (0146614)

- Move test logic from BroadlinkSteps to extension methods in TestServices - Remove registration methods from ISimulatedEnvironment (use constructor injection) - Rename ISimulatedDevice to ISimulatedTiVoDevice for clarity - Remove BoundPort property (use Port from base interface) - Update builders to accept ILoggerFactory instead of ILogger - Remove WithPort customization (always use ephemeral ports) - Simplify SimulatedEnvironment to construct devices directly Co-authored-by: jodavis <6740581+jodavis@users.noreply.github.com>

Replace code samples with links to actual implementation files in _doc_SimulatedDevices.md Co-authored-by: jodavis <6740581+jodavis@users.noreply.github.com>

jodavis · 2026-02-04T06:00:28Z

test/AdaptiveRemote.EndToEndTests.Steps/BroadlinkSteps.cs

+
+        RecordedPacket? irPacket = device.GetFirstPacketWithIrData();
+
+        if (irPacket == null)


Assert.IsNotNull instead

Initial plan

96cc530

Copilot AI assigned Copilot and jodavis Jan 29, 2026

Copilot started work on behalf of jodavis January 29, 2026 17:57 View session

Copilot AI and others added 7 commits January 29, 2026 18:01

Add simulated Broadlink device infrastructure and test integration

2878e1e

Co-authored-by: jodavis <6740581+jodavis@users.noreply.github.com>

Fix code warnings and build errors in simulated Broadlink device

eb3f11b

Co-authored-by: jodavis <6740581+jodavis@users.noreply.github.com>

Add configurable discovery endpoint for Broadlink testing

b553a0d

Co-authored-by: jodavis <6740581+jodavis@users.noreply.github.com>

Fix UDP client SendAsync calls to use correct API

c83ec96

Co-authored-by: jodavis <6740581+jodavis@users.noreply.github.com>

Fix simulated Broadlink device discovery and verification

a6cff4c

Co-authored-by: jodavis <6740581+jodavis@users.noreply.github.com>

Add comprehensive documentation for simulated devices

0e9cb94

Co-authored-by: jodavis <6740581+jodavis@users.noreply.github.com>

Address code review feedback: fix terminology, remove unused params, …

e36cc05

…improve documentation Co-authored-by: jodavis <6740581+jodavis@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Create simulated Broadlink device for E2E tests~~ Add simulated Broadlink device for E2E testing Jan 29, 2026

Copilot AI requested a review from jodavis January 29, 2026 18:29

Copilot finished work on behalf of jodavis January 29, 2026 18:29

jodavis requested changes Jan 29, 2026

View reviewed changes

Copilot started work on behalf of jodavis January 29, 2026 23:05 View session

Copilot AI and others added 2 commits January 29, 2026 23:16

Update documentation to link to code files instead of embedding samples

0146614

Replace code samples with links to actual implementation files in _doc_SimulatedDevices.md Co-authored-by: jodavis <6740581+jodavis@users.noreply.github.com>

Copilot AI requested a review from jodavis January 29, 2026 23:24

Copilot finished work on behalf of jodavis January 29, 2026 23:24

jodavis marked this pull request as ready for review January 30, 2026 04:48

jodavis approved these changes Feb 4, 2026

View reviewed changes

jodavis merged commit 69b7b89 into main Feb 4, 2026
2 checks passed


		RecordedPacket? irPacket = device.GetFirstPacketWithIrData();

		if (irPacket == null)


		### Core Interfaces

		```csharp

Conversation

Copilot AI commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Implementation Plan: Simulated Broadlink Device for E2E Testing

Implementation Checklist

Final Status

Comments on the Issue (you are @copilot in this section)

Uh oh!

github-actions bot commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

jodavis left a comment

Choose a reason for hiding this comment

Uh oh!

jodavis Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jodavis Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

jodavis Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jodavis Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

jodavis Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

jodavis Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Jan 29, 2026 •

edited

Loading

github-actions bot commented Jan 29, 2026 •

edited

Loading