Added options for icon fonts and custom HTML markup instead of icon#266
Open
EternallLight wants to merge 1 commit intojirikavi:masterfrom
Open
Added options for icon fonts and custom HTML markup instead of icon#266EternallLight wants to merge 1 commit intojirikavi:masterfrom
EternallLight wants to merge 1 commit intojirikavi:masterfrom
Conversation
Collaborator
|
Thank you for the pull request. This cannot be merged in without tests supporting the new functionality and withou maintaining 100% code coverage. |
Author
|
Ok, I will write the tests in my spare time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I implemented the given functionality, the result looks is the following:
The README file and minified CSS and JS have been updated.
Please check.