Provide separate bind setting to support use inside a container#31
Open
leopoldodonnell wants to merge 1 commit intojgsqware:masterfrom
Open
Provide separate bind setting to support use inside a container#31leopoldodonnell wants to merge 1 commit intojgsqware:masterfrom
leopoldodonnell wants to merge 1 commit intojgsqware:masterfrom
Conversation
…tainer When using a container, servers within typically need to bind to 0.0.0.0 to expose themselves externally to the container. This change supports a separate bind address from the container's IP that needs to be relayed to clair to deliver responses and notifications.
jgsqware
reviewed
Apr 25, 2017
| if viper.GetString("clairctl.bind_addr") != "" { | ||
| listenOn = viper.GetString("clairctl.bind_addr") + ":" + viper.GetString("clairctl.port") | ||
| } | ||
| log.Debugf("Listinging on: %s", listenOn) |
Owner
There was a problem hiding this comment.
there is a typo here: "Listinging"
Owner
|
Thanks for your contribution. There is a little typo, after you've fixed it, I'll merge the PR |
jgsqware
force-pushed
the
master
branch
3 times, most recently
from
64edd0f to
29a1925
Compare
Collaborator
|
Is this still required ? clairctl works fine in a container without the need for this fix. |
Owner
|
And you already specify the interface too
Le mer. 19 juil. 2017 17:50, Julien Del-Piccolo <notifications@github.com>
a écrit :
… Is this still required ? clairctl works fine in a container without the
need for this fix.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#31 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADJrq3h_U4fEn-VOktQaSXM3jWK-sH_7ks5sPiWzgaJpZM4NDvQA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a container, servers within typically need to bind to 0.0.0.0 to expose themselves
externally to the container. This change supports a separate bind address from the container's
IP that needs to be relayed to clair to deliver responses and notifications.
I'm not the original author, so it's not always easy to provide the best answer, I'm open to addressing this differently. This change tries to make a minimal change more or less in keeping with the surrounding code.