Skip to content

Conversation

@eranturgeman
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

This PR fixes 2 things:

  1. names of functions that were incorrect/ not very clear
  2. potential bug that can cause the utilized gitManager to point its local git repository (.git) to a deleted repo, leaving it in an invalid state
    Explanation: Since we can iterate several branches in scan-repo, for each branch we work in a temp dir and return to the original dir at the end. When returning to the original dir we set the cur wd to the original dir and delete the temp one. I noticed that we missed setting the .git repo to the original on. This may cause if some failure happens to leave the gitManager pointing to a .git repository that no longer exists

@eranturgeman eranturgeman added bug Something isn't working safe to test Approve running integration tests on a pull request labels Dec 30, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 30, 2025
@eranturgeman eranturgeman requested a review from eyalk007 January 1, 2026 07:40
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jan 4, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 4, 2026
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jan 4, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 4, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

👍 Frogbot scanned this pull request and did not find any new security issues.


@eranturgeman eranturgeman merged commit bb7bc1b into jfrog:v3_er Jan 4, 2026
18 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants