-
Notifications
You must be signed in to change notification settings - Fork 88
Simplify getResultScanStatus #1014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3_er
Are you sure you want to change the base?
Simplify getResultScanStatus #1014
Conversation
|
only thing to check is to validate if working dir isnt coming back as a concept next q if it does maybe the simplification isnt worth it |
This question if in place but if it does come back soon - we need to think if having separate working dirs means separate scans. if not - we still only have one set of results. if we do perform separate scans (I think we should in order to enable defining different settings to different parts of the repo, the cc "modules") so Eyal is correct and this change is not valid |
eyalk007
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets discuss with or about the nil check
…y-getResultScanStatus

This PR simplify the getResultsScanStatus by stop considering several SecurityCommandResults.
Since we Deprecated the Projects and WorkingDirs concepts, it seems like we cannot get several scan results from a single run, therefore we take the scans statuses from the single scan we have.