Update to iOS12 Minimum Target. #648
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update minimum targets to 12.0 so they can be built in XCode 15
Author
|
@matej Can you please look at this PR? I've unblocked my team through using my fork, but the official version should be updated to support XCode 15. |
## 🚢 Major? Minor? Patch? - Patch ## 🚧 PR risk (highest?, high?, medium?, low?, lowest?) - Lowest ## 👪 Related PRs - N/A ## ✅ Acceptance Criteria - Add privacy manifest file to satisfy Apple's upcoming submission requirements ## 🤔 What does this PR do? - Added PrivacyInfo.xcprivacy ## 🎯 Where should the reviewer start? - PrivacyInfo.xcprivacy ## 👩🔬 How should this be manually tested? - Nothing to do here really as long as the file exists. ## 📖 Any background context you want to provide? - See https://developer.apple.com/support/third-party-SDK-requirements/
hystericcore
reviewed
Mar 5, 2024
Added `resource_bundles` in Cocoapods to include the PrivacyInfo file to the bundle to support static linking. Can refer to the related discussion from the below links. SnapKit/SnapKit#798 CocoaPods/CocoaPods#10325 (comment) Co-authored-by: Hyun Joon Park <hystericcore@icloud.com>
hystericcore
approved these changes
Mar 15, 2024
stephengurnett
approved these changes
Mar 15, 2024
fcar12
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update minimum targets to 12.0 so they can be built in XCode 15
This fixes #641
This should be a Major release (i.e. 2.0.0) because it is removing support for iOS 8-11.