Open
Conversation
- Set up web sign-in via rel-me - Add info about owner via h-card - Add microformats to content via h-entry
jbub
requested changes
Jun 3, 2018
Owner
jbub
left a comment
jbub
left a comment
There was a problem hiding this comment.
Thanks for your contribution, just a simple fix and we are ready to merge it :)
layouts/partials/footer.html
Outdated
| class="p-name u-url url author metatag" rel="me"> | ||
| {{ .Site.Author.name }} | ||
| </a> / | ||
| <a class="p-nickname u-email email metatag" rel="me" |
Owner
There was a problem hiding this comment.
We need to check if Site.Author.nick and Site.Author.email are set and only then render this block.
Author
There was a problem hiding this comment.
Sure, I think this check would be important. I will incorporate the change and resubmit. Thank you!
Author
There was a problem hiding this comment.
I have added a check for this and made a new commit.
Added check for Site.Author.nick and Site.Author.email being set set. Only if they are set to a non-empty value, the relevant block will be rendered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IndieWeb is a trending project, focused mainly on allowing website owners to own and control their content, and also stay connected with engagement on them across services. All it needs is availability of some key classes on elements. This does not need any action on user's part, at the same time enabling below.