Open
Conversation
Author
|
Also your vCard Instance does not holds any data, so creating instance of vCard is absolutely unnecessary. |
Owner
|
Hi! Sorry for completely missing your awesome work. Would it be possible to rebase your commit? |
|
Please don't give the method the same name as the object. It should be: VCard.Parse(); VCard can be a class with a static method named "Parse". In fact, the logic to read from file should be removed in my opinion. The logic to read from file is the responsibility of the user and not of this module. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your library implementation does not use any asynchronous APIs. It will be cool if users will be able to use your library without any callbacks too, with no effect to performance.