Skip to content

Conversation

@heartsucker
Copy link

Fixes #158

self.curkey['subkeys'].append(subkey)

def rvk(self, args):
self.curuid == None
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this revocation key packet in your error example at #158.

Why are you reseting the curuid when you find a revocation key?

Copy link
Owner

@isislovecruft isislovecruft Dec 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the revocation packet is on a different UID, at the very end:

rev:::1:C0A2586F09D77C82:1471422777::::heartsucker <heartsucker@autistici.org>:28x:::::10:

But I still don't understand why one would reset curuid…

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My assumption is that this line is a typo, it should be

 if self.curuid == None:
            return

like in the other lines.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember why I reset curuid, but that fixed the problem at the time. I'm trying to get back and understand what I did and why.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isislovecruft @meskio Ok, I remember what happened here. In the original issue, I posted the output of what I thought was the key that was causing the problem.

However, the problem (I think) was that the key before the one that was erring out had either a) no subkeys and one revocation cert or b) the last key was revoked. This did something like causing the next key to be parsed to attempt to access a dict member that was based off a key that didn't exist.

Because this was something I was doing at an old job, I don't have access to the key in question to share the output (and it may have changed since then anyway).

@heartsucker
Copy link
Author

Heya. Slow response because I'm trying to find the key that caused this error in the first place so I can reliably reproduce this. I'll get back soon (promise).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants