Add general validation checks for attribute dtypes, string dtypes, placeholder values#155
Open
nemo794 wants to merge 3 commits intoisce-framework:mainfrom
Open
Add general validation checks for attribute dtypes, string dtypes, placeholder values#155nemo794 wants to merge 3 commits intoisce-framework:mainfrom
nemo794 wants to merge 3 commits intoisce-framework:mainfrom
Conversation
for more information, see https://pre-commit.ci
nemo794
force-pushed
the
check_for_not_specified
branch
from
e5f6fb1 to
138a67c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #59
Closes #17
Addresses part of #128
This PR validates that all datasets and attributes meet certain NISAR conventions, and logs an error if issues are found.
It checks all datasets and attributes for:
1) populated (not empty)
2) if string, that they are not variable-length strings and that they are not populated with known placeholder values.
3) if an attribute is numeric and is in given set of names, that its dtype corresponds to its dataset's dtype.