Allow non-integer margin in stage_dem and stage_watermask#121
Open
gmgunter wants to merge 1 commit intoisce-framework:developfrom
Open
Allow non-integer margin in stage_dem and stage_watermask#121gmgunter wants to merge 1 commit intoisce-framework:developfrom
stage_dem and stage_watermask#121gmgunter wants to merge 1 commit intoisce-framework:developfrom
Conversation
gmgunter
requested review from
gshiroma,
hfattahi,
oberonia78,
rad-eng-59 and
vbrancat
rad-eng-59
approved these changes
Aug 28, 2025
Contributor
rad-eng-59
left a comment
rad-eng-59
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix.
gmgunter
force-pushed
the
stage-dem-margin-float
branch
from
69304fd to
d8e1d17
Compare
gmgunter
force-pushed
the
stage-dem-margin-float
branch
from
d8e1d17 to
6a8a953
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
stage_dem.pyandstage_watermask.pyto allow specifying a non-integer-valued--marginoption.h/t @rad-eng-59 who suggested this improvement.