Add Map support
#154
Draft
Add Map support
#154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I'll most likely revisit this when I redo the config of my Biome Fog mod. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
Maps, with any existing controller type as a supported key/value controller.Entries can be moved up/down, added, and removed, similar to
Lists.I left 2 TODO comments in the code, for some slightly cursed stuff that I don't know how to handle.
I still need to add a GUI element for the values of entries. Currently only keys are displayed. Also, typing crashes the game currently.
This is also in part due to the TODO comments mentioned above.
Will need a lot of work to be usable.
Feel free to suggest improvements and changes.