Cisco NXOS vPC Domain #96
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikatza
force-pushed
the
cisco-nxos-vpc
branch
from
7a146d3 to
57755c4
Compare
hardikdr
added
the
area/metal-automation
nikatza
force-pushed
the
cisco-nxos-vpc
branch
2 times, most recently
from
0b789b3 to
52078ca
Compare
nikatza
force-pushed
the
cisco-nxos-vpc
branch
from
52078ca to
b960688
Compare
nikatza
force-pushed
the
cisco-nxos-vpc
branch
11 times, most recently
from
218ebd5 to
2f2cd99
Compare
nikatza
force-pushed
the
cisco-nxos-vpc
branch
10 times, most recently
from
f6fb13c to
b3fd3db
Compare
nikatza
force-pushed
the
cisco-nxos-vpc
branch
from
b3fd3db to
5fede6d
Compare
nikatza
force-pushed
the
cisco-nxos-vpc
branch
8 times, most recently
from
509e272 to
cb86bf5
Compare
nikatza
force-pushed
the
cisco-nxos-vpc
branch
8 times, most recently
from
9fe01a4 to
a046ec2
Compare
nikatza
force-pushed
the
cisco-nxos-vpc
branch
from
a046ec2 to
5abe136
Compare
nikatza
force-pushed
the
cisco-nxos-vpc
branch
2 times, most recently
from
e39fa48 to
6e86fa3
Compare
Comment on lines
+98
to
+94
| // +kubebuilder:validation:Maximum=65535 | ||
| VPCId int32 `json:"vpcId"` |
Contributor
There was a problem hiding this comment.
this field seems unused.
| ) | ||
|
|
||
| // parsePeerUptime parses the peerUpTime string returned by the device. | ||
| // It assumes time is formatted as "(<seconds>) seconds"; e.g., "(3600) seconds". |
Contributor
There was a problem hiding this comment.
| oldVRF := e.ObjectOld.(*corev1.VRF) | ||
| newVRF := e.ObjectNew.(*corev1.VRF) | ||
| return oldVRF.Spec.Name != newVRF.Spec.Name || | ||
| !equality.Semantic.DeepEqual(oldVRF.Status, newVRF.Status) |
Contributor
There was a problem hiding this comment.
What is the reason that we should trigger a reconcilation once the vrf status changes? 🤔 Same applies to interface above.
Contributor
Author
There was a problem hiding this comment.
I can't reconstruct forvrf, but for interface: the switch can shutdown the port-channels that form the peer link, so I wanted to force a reconciliation to update the vpc domain status. If you prefer I can remove it.
Contributor
There was a problem hiding this comment.
Makes sense. Could we then make the check a bit more specify? E.g. checking for a transition in the operational condition? I'm just a bit worried, that if we check for equality in the whole status subresource, we might end up adding more unrelated properties to the status later, which will then trigger unecessary reconcilations of the vpc domain, for something that doesn't effect the vpc domain. So basically, only checking for things, that we actively account for in the vpc domain.
Multi-Chassis Link Aggregation (MC-LAG) is quite vendor and platform specific. We don't see much intersection in their respective configuration to justify a common API type. Instead, we move forward with a platform specific API exclusive to Cisco NXOS devices. This commit adds new types, controller, and provider to configure virtual Port Channels (vPCs) via the operator.
Use `nx.cisco.networking.metal.ironcore.dev/channel-group-force` to tag an interface of type `Aggregate` on a Cisco NX device and force the addition of member interfaces to the port-channel. The value of the annotation is ignored.
nikatza
force-pushed
the
cisco-nxos-vpc
branch
from
6e86fa3 to
ae543e1
Compare
Merging this branch changes the coverage (2 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-Chassis Link Aggregation (MC-LAG) is quite vendor and platform
specific. We don't see much intersection in their respective
configuration to justify a common API type. Instead, we move forward
with a platform specific API exclusive to Cisco NXOS devices.
In this PR we add types, controller, and provider code to configure
virtual Port Channels (vPCs) via the operator as:
The
vpcdomaincontroller ensures that thevpc peer-linkis configured.This is because on gNMI this property is configured at the vpcDom (sub-)containers.
Having this property as a provider-specific resource does not seem a good
option and the moment as it complicates the code base.
The operational status of the resource is
UPif the peer is alive and the remotedevice returns a positive uptime value for the peer.