ipynb to py for helper files #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
There was a problem hiding this comment.
This looks great - couple of changes I would recommend:
_paras->_paramsin the title and everywhere else?- Can we change this to a .yml file instead of .py? Better convention so it is easier to spot by people who may want to modify the settings.
…he config_training_NN_parms.yml
gsharma99
commented
Dec 25, 2025
|
|
||
| NN_training_syst_process[process][syst][direction].train_ensemble(**sys_training_params) | ||
|
|
||
| # NN_training_syst_process[process][syst][direction].test_normalization() |
Contributor
Author
There was a problem hiding this comment.
I believe this part generates plots. I've commented it for now but let me know if we aim for a different execution here!
gsharma99
commented
Dec 25, 2025
| logger.info("Executing Training Loop...") | ||
|
|
||
| # If --train is passed, we FORCE training, ignoring 'load_trained_models' in YAML if needed | ||
| # sys_training_params['load_trained_models'] = False |
Contributor
Author
There was a problem hiding this comment.
The step two onwards runs only when --train is passed as argument. In that case, should I force the load_trained_models to False, irrespective if what is being passed in the config?
gsharma99
commented
Dec 25, 2025
|
|
||
| # Trim the dataset, so all processes have equal entries | ||
|
|
||
| # Here the notebook implemented the the number of ttbar events (lowest) |
Contributor
Author
There was a problem hiding this comment.
This is also a little different implementation form the notebook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipynb to py for the hpc workflow.
related issue #12