Fix: Move callback and YAML messages from 'verbose' to 'debug' class #3000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR refactors verbose logging to use debug flags, reducing noise when running netlab create --verbose. It also fixes a test regression where warnings were incorrectly suppressed during error testing.
Key changes:
- Introduced
NO_WARNINGflag to separate warning suppression from quiet mode - Moved callback module loading messages from verbose to
debug('loadable') - Removed verbose YAML file reading message that cluttered output
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| netsim/utils/log.py | Adds NO_WARNING flag to fix test error handling, updates global variable declarations for better organization |
| netsim/utils/callback.py | Replaces verbose checks with debug_active('loadable'), improves exception handling, removes unused sys import |
| netsim/utils/read.py | Improves exception handling from bare except to Exception as ex, removes verbose logging message |
| netsim/cli/init.py | Adds 'loadable' to debug flag choices to support new debug category |
| tests/errors/invalid-yaml.log | Updates test output to reflect corrected warning behavior in error tests |
'netlab create --verbose' generated tons of messages that were really debugging messages. Now they're printed only if the corresponding 'debug' flag is active. Also: fix 'test errors => QUIET => no warnings' problem introduced in f92490e that broke the error tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'netlab create --verbose' generated tons of messages that were really debugging messages. Now they're printed only if the corresponding 'debug' flag is active.
Also: fix 'test errors => QUIET => no warnings' problem introduced in f92490e that broke the error tests.