-
Notifications
You must be signed in to change notification settings - Fork 24
export: cache serialized values #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@max-ipinfo extracted CSV/TSV/JSON exports to dedicated type exporter interface {
WriteRecord(result maxminddb.Result) error
Flush() error
}Also simplified a little the JSON logic. It's a bit slower (15s -> 24s) but still much faster than the current version. |
Just curious. Why would moving it to an |
|
Oh sorry, I was unclear 😄 It's not the interface but the JSON simplification that slows down things a bit. Instead of manually writing |
Make use of the new v2 API (#47) to cache decoded and serialized MMDB values.
Testing on a 1GB MMDB file:
@max-ipinfo this is the raw Claude output which I might cleanup a bit, but it seems to work as expected.