Open
Conversation
Simple copy&paste mistake, the output label must match the config key. Fixes: 1d7fc77 ("lldp: Allow lldptool to modify optional TLV's content") Signed-off-by: Marko Hauptvogel <marko.hauptvogel@tu-dresden.de>
Simple copy&paste mistake, the test-flag needs to be true here. Fixes: 092a3d7 ("lldptool: support multiple arguments instead of one") Signed-off-by: Marko Hauptvogel <marko.hauptvogel@tu-dresden.de>
Contributor
|
Looks reasonable, but I want to refresh myself on this code before marking it approved. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes two copy-paste errors in the LLDP basman commands implementation:
- Corrects an incorrect output message in
_set_arg_infothat was displaying "enableTx" instead of "info" - Fixes
test_arg_ipv6to passtrueinstead offalseto the underlying function, making it consistent with other test functions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two small copy&paste mistakes.
And a related piece of information for future researching users: To change the
sysNameTLV value (for example to the FQDN), you can uselldptool -i eth0 -T -V sysName info=myhost.example.org. This config option is unfortunately not listed bylldptool -i eth0 -t -V sysName -cuntil you set it.