add local fee to XcmFeeParams and charge caller#292
Merged
Conversation
brenzi
changed the title
clangenb
reviewed
Aug 26, 2025
porteer/src/lib.rs
Outdated
Comment on lines
390
to
396
| let user_fee = Self::xcm_fee_config().local; | ||
| <T::Fungible as fungible::Mutate<_>>::transfer( | ||
| &signer, | ||
| &T::FeeCollectorAccount::get(), | ||
| user_fee, | ||
| Preservation::Preserve, | ||
| )?; |
Contributor
There was a problem hiding this comment.
I am confused. I thought we want to charge the fees of all hops here? If it is just for local execution fees, we can do it in the Porteer's XCM implementation, no need to charge it here in the pallet.
Contributor
Author
There was a problem hiding this comment.
I don't want to complicate the XCM even more. The idea is to charge the equivalent sum of all fees (which the sovereign account will pay along the hops) by the user at equivalent value.
We need to send this equivalent fee to the treasury for sustainable funding of the sovereign account
I renamed the field to avoid confusion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #290