This repository was archived by the owner on Dec 22, 2018. It is now read-only.
Open
Conversation
1. Copy the shared folder to docs/shared instead of docs/shared/shared. 2. Use docs/ instead of web/ as content-base because web/ doesn't exist. 3. Add $* to allow optional argument such as passing --port to use another port.
Prevent invoking UI.renderPage on the same page more than once as that will corrupt the result.
This was referenced Dec 27, 2017
|
This should definitely be merged. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 things as described by the commits.