Additional configuration parameters #142
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optiz0r
reviewed
Jan 23, 2026
| response-policy { | ||
| <%- @response_policy['zones'].each do |rpz_zone_name,rpz_zone| -%> | ||
| zone <%= "\"#{rpz_zone_name}\"" -%> | ||
| <%- if @rpz_zone -%> |
There was a problem hiding this comment.
I realise this PR is very old now but I found it useful and have just patched it into my workplace fork. For what it's worth, there's a bug on this line, @rpz_zone should be rpz_zone. As the code stands now, none of the per-zone overrides are rendered into the view config since the conditional always fails as the instance variable does not exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
response-policy,
listen-on,
query-source,
allow-query,
server-addresses.
Changed:
default_zones_include can accept arrays now