Non-admin CRUD views for ParticipationTag and ParticipationRole#745
Open
dzhuang wants to merge 5 commits intoinducer:mainfrom
Open
Non-admin CRUD views for ParticipationTag and ParticipationRole#745dzhuang wants to merge 5 commits intoinducer:mainfrom
dzhuang wants to merge 5 commits intoinducer:mainfrom
Conversation
dzhuang
changed the title
Owner
|
FYI Github has a "draft" mode for PRs to express "WIP" status (under "Reviewers" in the sidebar). |
Owner
|
That's also where you can request a review once you think it's ready for a look. |
Contributor
Author
|
Thanks for the information.
|
dzhuang
changed the title
inducer
reviewed
Oct 26, 2020
Owner
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
Thanks for your work on this. Some comments below.
dzhuang
force-pushed
the
ptag_crud
branch
2 times, most recently
from
03fee06 to
c48e0f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing #299 and #303